Fix tests so they work with jQuery>2.0 as well as the older versions#155
Closed
hankhero wants to merge 3 commits intorstacruz:masterfrom
Closed
Fix tests so they work with jQuery>2.0 as well as the older versions#155hankhero wants to merge 3 commits intorstacruz:masterfrom
hankhero wants to merge 3 commits intorstacruz:masterfrom
Conversation
Changed .live handlers to .click etc that works in all jQuery versions
Author
|
Note, there are also two patches here testing and fixing an issue. |
|
+1 For this. Live() is deprecated since jQuery 1.7 http://api.jquery.com/live/ Tried the proposed change in 23e3e6e and it works! |
Owner
|
Thanks! transit.js has diverged a bit since then, though, so I can't merge this in... but I'm definitely interested in getting the test/index.html updates in |
Owner
|
cherry-picked, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed .live handlers to .click etc that works in all jQuery versions